You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2397

Built from 211348f

In theory nim-libp2p should use Yamux for go-libp2p interop and fall back to Mplex if needed right?

I tried using wakunode2 and it could connect succesfully against peers that support only yamux or only mplex, or both!

Since the order of multiplexers matter, it's added after mplex so it continues being the default multiplexer

If a peer supports both mplex and yamux, then yamux would be used right?
mplex would only be used if a peer doesn't support yamux.

@chaitanyaprem @Ivansete-status
If i understood correctly the code in https://github.com/status-im/nim-libp2p/blob/eb0890cd6f5d36e1b3ae414bffda59d31dfc2e7c/libp2p/upgrademngrs/muxedupgrade.nim#L43-L45 nim-libp2p will try muxers depending on the order they're defined both in identify protocol and when building the switcher, so it is like @Ivansete-status says: it will attempt to use mplex first, and if not available, then yamux.

So with the changes of this PR, if for ex, if go-waku returns via identify protocol the muxers protocol ids in this order: [yamux_protocol_id, mplex protocol_id], nim-libp2p will use yamux first. But if go-waku were to return [mplex_protocol_id, yamux_protocol_id], since in the switcher mplex is used as default (we called withMplex before withYamux), then it will prefer to use mplex over yamux.

We could switch the order, but i went with mplex by default, since that's what nwaku nodes out there in the wild are using, and eventually just use yamux?